Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appbar): does not pass any additional props to Searchbar component #972

Merged
merged 1 commit into from
Apr 16, 2019
Merged

fix(appbar): does not pass any additional props to Searchbar component #972

merged 1 commit into from
Apr 16, 2019

Conversation

brunohkbx
Copy link
Collaborator

@brunohkbx brunohkbx commented Apr 3, 2019 •
edited
Loading

Fix #605

@callstack-bot
Copy link

callstack-bot commented Apr 3, 2019 •
edited
Loading

Hey @brunohkbx, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@brunohkbx brunohkbx force-pushed the fix/search-bar branch 3 times, most recently from 318f767 to f4b2197 Compare April 4, 2019 18:04
@brunohkbx brunohkbx changed the title fix: Doesn't pass ...rest prop to TextInput component on Searchbar fix(appbar): does not pass any additional props to Searchbar component Apr 4, 2019
@brunohkbx
Copy link
Collaborator Author

brunohkbx commented Apr 4, 2019 •
edited
Loading

Hey @satya164 @Trancever. My initial approach was to remove the ...rest props passed to TextInput, but there are some meaningful cases like passing autoFocus.
Thus, I just have checked if the children are a searchbar.
What do you guys think?

@jayu
Copy link
Contributor

jayu commented Apr 15, 2019

Hi @brunohkbx! Thank you for your interest in this issue. I've checked your solution and I think we can do it better. Please check my comment.
Let me know if you have time for changing your PR or I will handle this

jayu
jayu suggested changes Apr 15, 2019
View reviewed changes
src/components/Appbar/Appbar.js Outdated Show resolved Hide resolved
@brunohkbx
Copy link
Collaborator Author

Thanks for reviewing the changes @jaysbytes. I've already pushed your suggestions. 😁

@jayu
Copy link
Contributor

jayu commented Apr 15, 2019

Now the fix looks legit. WDYT @Trancever, can we merge?

@jayu jayu merged commit d95bb8b into callstack:master Apr 16, 2019
@brunohkbx brunohkbx deleted the fix/search-bar branch April 16, 2019 11:00
@brunohkbx brunohkbx mentioned this pull request Apr 17, 2019
Merged
jbinda pushed a commit to jbinda/react-native-paper that referenced this pull request Apr 17, 2019
@brunohkbx @jbinda
fix(appbar): do not pass any additional props to custom children comp…
337badc 
…onents (callstack#972)
iyadthayyil pushed a commit to iyadthayyil/react-native-paper that referenced this pull request Jun 6, 2019
@brunohkbx @iyadthayyil
fix(appbar): do not pass any additional props to custom children comp…
a15a47c 
…onents (callstack#972)
@iyadthayyil iyadthayyil mentioned this pull request Jun 14, 2019
Closed
Trancever pushed a commit that referenced this pull request Jun 27, 2019
@brunohkbx @Trancever
fix(appbar): do not pass any additional props to custom children comp…
446ad94 
…onents (#972)
@fabian-astorga fabian-astorga mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayu jayu jayu approved these changes

Assignees

@jayu jayu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searchbar crashes on Android when wrapped in Appbar
3 participants
@brunohkbx @callstack-bot @jayu