Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom icon for clear in seachbar #965

Merged
merged 1 commit into from
Apr 15, 2019
Merged

feat: custom icon for clear in seachbar #965

merged 1 commit into from
Apr 15, 2019

Conversation

raajnadar
Copy link
Collaborator

Motivation

Closes #707

Test plan

<Searchbar
      placeholder="Search"
      value="Test"
      clearIcon="custom-icon-name"
/>

@callstack-bot
Copy link

callstack-bot commented Mar 30, 2019 •
edited
Loading

Hey @raajnadar, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@ferrannp
Copy link
Collaborator

Thank you!

@ferrannp ferrannp merged commit 5e163e3 into callstack:master Apr 15, 2019
jbinda pushed a commit to jbinda/react-native-paper that referenced this pull request Apr 17, 2019
@raajnadar @jbinda
feat: custom icon for clear in seachbar (callstack#965)
aded6b8
iyadthayyil pushed a commit to iyadthayyil/react-native-paper that referenced this pull request Jun 6, 2019
@raajnadar @iyadthayyil
feat: custom icon for clear in seachbar (callstack#965)
d364212
@iyadthayyil iyadthayyil mentioned this pull request Jun 14, 2019
Closed
Trancever pushed a commit that referenced this pull request Jun 27, 2019
@raajnadar @Trancever
feat: custom icon for clear in seachbar (#965)
c23d4eb
@fabian-astorga fabian-astorga mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trancever Trancever Awaiting requested review from Trancever

@pbitkowski pbitkowski Awaiting requested review from pbitkowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to change a clear icon in Searchbar
3 participants
@raajnadar @callstack-bot @ferrannp