Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed images linking to incorrect path #3837

Merged
merged 1 commit into from
Apr 26, 2023
Merged

docs: Fixed images linking to incorrect path #3837

merged 1 commit into from
Apr 26, 2023

Conversation

Aadniz
Copy link
Contributor

@Aadniz Aadniz commented Apr 22, 2023

Path to images didn't link to anything, now it should link correctly, at least according to the docs at https://callstack.github.io/react-native-paper/docs/guides/react-navigation/

Summary

Fixed images linking to incorrect path

Test plan

Tested directly on https://callstack.github.io, changing the links from ../../ to /react-native-paper/ makes them show up

@callstack-bot
Copy link

callstack-bot commented Apr 22, 2023

Hey @D3faIt, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak
Copy link
Member

Hey @D3faIt, please adjust the commit message according to the contribution guide

@Aadniz Aadniz changed the title Fixed images linking to incorrect path docs: Fixed images linking to incorrect path Apr 25, 2023
@Aadniz
Copy link
Contributor Author

Aadniz commented Apr 25, 2023

Thank you. Title has been updated

@lukewalczak
Copy link
Member

Hey @D3faIt, you've updated the PR title, however I asked about the commit message.

@Aadniz
Copy link
Contributor Author

Aadniz commented Apr 25, 2023

Sorry for the fuzz, we learn something every day.

I believe it should all be within contributing guidelines now

@lukewalczak lukewalczak merged commit 3dacabd into callstack:main Apr 26, 2023
This was referenced Apr 26, 2023
@Aadniz Aadniz deleted the patch-1 branch April 26, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants