fix: data table header title number of lines not working #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
tjaniczek
approved these changes
Mar 22, 2023
| @@ -83,7 +83,9 @@ const DataTableExample = () => { | |||
| > | |||
| Dessert | |||
| </DataTable.Title> | |||
| <DataTable.Title numeric>Calories</DataTable.Title> | |||
| <DataTable.Title numberOfLines={2} numeric> | |||
There was a problem hiding this comment.
It would be nice to add alignItems: 'center' to the styles.container since we can have multiline headers:
teneeto
pushed a commit
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Data table column titles were stuck on one line, even if numberOfLines > 1.
The problem was that data table header had a fixed height of 48 px.
I updated the data table in the example app to include a column title with two lines.
This issue was reported on #3753.
Test plan
You can use the data table sample on the example app and tweak the numberOfLines and title text.
Right now, the second column is set to show the column title in 2 lines as you can see below: