refactor: fix performance of InputLabel #3662
Merged
+152
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjaniczek
force-pushed
the
refactor-input-label-performance
branch
from
c939c2a
to
40b7227
Compare
DimitarNestorov
approved these changes
Feb 7, 2023
|
Hey @tjaniczek, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Another round of performance improvements over
TextInput. This time we managed to memoizeInputLabelso it does not re-render on each key stroke.Essentially to do so, I had to inline the
parentStateandlabelPropsobjects, so that reconciler has a chance to diff changes in props. Previously both objects would be created on each render.This work results in slower first render (10% comparing to previous) but faster response on each key stroke (by 25%)
Test plan
Click through in the example app. No changes to the previous implementation should occur.