fix: allow for custom variants in Text (with factory)
#3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @DimitarNestorov, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
DimitarNestorov
force-pushed
the
fix/custom-variants-in-text-generic-factory
branch
2 times, most recently
from
a45d00f
to
8d342c2
Compare
lukewalczak
reviewed
Feb 7, 2023
lukewalczak
reviewed
Feb 7, 2023
DimitarNestorov
force-pushed
the
fix/custom-variants-in-text-generic-factory
branch
from
8d342c2
to
ef368b7
Compare
jaworek
approved these changes
Feb 7, 2023
DimitarNestorov
force-pushed
the
fix/custom-variants-in-text-generic-factory
branch
from
ef368b7
to
66e403b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3658
Closes #3659
Test plan
CI passes. Example works as expected.