Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style types #3623

Merged
merged 13 commits into from
Feb 6, 2023
Merged

Conversation

DimitarNestorov
Copy link
Contributor

@DimitarNestorov DimitarNestorov commented Jan 25, 2023

Summary

Related to #3618

Depends on #3631

Some style props didn't accept Animated.Value.

Test plan

Added tests with a style containing a Animated.Value. CI should pass.

@callstack-bot
Copy link

callstack-bot commented Jan 25, 2023

Hey @DimitarNestorov, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@DimitarNestorov DimitarNestorov marked this pull request as draft January 25, 2023 14:35
@DimitarNestorov DimitarNestorov changed the title Fix style types fix: style types Jan 25, 2023
@DimitarNestorov DimitarNestorov marked this pull request as ready for review January 26, 2023 14:29
Copy link
Contributor

@gedu gedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome work

@lukewalczak
Copy link
Member

@DimitarNestorov please solve the conflicts 🙏🏽

@lukewalczak lukewalczak merged commit 0556ba6 into callstack:main Feb 6, 2023
@DimitarNestorov DimitarNestorov deleted the chore/fix-style-types branch February 6, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants