fix: TypeScript bloat #3603
Merged
fix: TypeScript bloat #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
reviewed
Jan 20, 2023
satya164
reviewed
Jan 20, 2023
DimitarNestorov
force-pushed
the
chore/fix-typescript-bloat
branch
from
2fa7496
to
cf1360c
Compare
lukewalczak
reviewed
Jan 20, 2023
satya164
reviewed
Jan 20, 2023
DimitarNestorov
force-pushed
the
chore/fix-typescript-bloat
branch
from
cf1360c
to
d6be7bb
Compare
DimitarNestorov
force-pushed
the
chore/fix-typescript-bloat
branch
from
d6be7bb
to
5adc5df
Compare
|
Hey @DimitarNestorov, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
reviewed
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #3595 #3517
The
lib/typescriptfolder is filled with a lot of bloat (as shown in screenshot below). This PR removes all instances of that kind of bloat and adds a script to prevent a regression.For example: the source code doesn't contain any
accessibilityLabelledBybut there are 40 occurrences inlib/typescript. This causes an issue in React Native 0.71 where this prop has a type of unknown and is required (the prop is missing from the type definitions in 0.71.0).Test plan
Ran
yarn test,yarn lint, andyarn typescriptwith no errors.