feat: add babel plugin for modular imports #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Apr 14, 2018
scripts/validate-commit-message.js
Outdated
| if (!TYPES.hasOwnProperty(type)) { | ||
| printError('"%s" is not allowed type !', type); | ||
| if (!TYPES.includes(type)) { | ||
| printError('"%s" is not an allowed type !', type); |
There was a problem hiding this comment.
while you're at fixing grammar, could you remove that extra space before ! here an in line 35?
satya164
force-pushed
the
@satya164/babel
branch
2 times, most recently
from
ced47cc
to
e99d268
Compare
satya164
changed the title
satya164
force-pushed
the
@satya164/babel
branch
from
e99d268
to
c483a52
Compare
satya164
force-pushed
the
@satya164/babel
branch
from
c483a52
to
2b94926
Compare
ferrannp
approved these changes
Apr 17, 2018
eriveltonelias
pushed a commit
to eriveltonelias/react-native-paper
that referenced
this pull request
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108