chore: add Git Hook to validate commit messages #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommezz
force-pushed
the
validate-commit-msg
branch
from
223be82
to
42b89d6
Compare
satya164
reviewed
Jul 4, 2017
| @@ -0,0 +1,58 @@ | |||
| const fs = require('fs'); | |||
There was a problem hiding this comment.
Use Flow if it doesn't need annotations
There was a problem hiding this comment.
Should I? There are only 2 functions to annotate, one with string type and buffer type, which is a node object. I don't see that much value
There was a problem hiding this comment.
@rauliyohmc flow provides autocomplete
satya164
requested changes
Jul 4, 2017
| perf: true, | ||
| test: true, | ||
| chore: true, | ||
| revert: true, |
scripts/validateCommitMessage.js
Outdated
|
|
||
| const commitMsgFile = process.argv[2]; | ||
|
|
||
| fs.readFile(commitMsgFile, function(err, buffer) { |
There was a problem hiding this comment.
maybe fs.readFileSync is better since it's a script
satya164
approved these changes
Jul 5, 2017
satya164
force-pushed
the
validate-commit-msg
branch
from
7584761
to
75be76d
Compare
satya164
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.