docs: Adding <Text> to avoid errors #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying the code and trying in the editor, an error is returning, demanding that the "This is a scrollable area" text be wrapped in a `<Text>` component.
|
Hey @rodriigovieira, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API. |
rodriigovieira
changed the title
|
@rodriigovieira can you import |
|
I just did. Did I do it correctly? |
|
Yup, thank you! |
ferrannp
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change
Add a
<Text>in the documentation of theDialog.ScrollAreato avoid errors while copying without making changes.When copying the code and trying it in the editor, an error is returned, demanding that the "This is a scrollable area" text be wrapped in a
<Text>component.Although in most cases the scrollable content won't be a
<Text>component, I think it would nice to do something to avoid the error. As an alternative, a<View>with a few<Text>inside could be added.Motivation
By fixing this, it'll avoid errors by beginners or by someone who's just copying the code and trying to check things out, avoiding the unnecessary trouble.