Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contentContainerStyle to ModalProps interface #1052

Merged
merged 3 commits into from
May 9, 2019
Merged

Add contentContainerStyle to ModalProps interface #1052

merged 3 commits into from
May 9, 2019

Conversation

Taym95
Copy link
Collaborator

@Taym95 Taym95 commented May 6, 2019

Fix #1051

@callstack-bot
Copy link

callstack-bot commented May 6, 2019

Hey @Taym95, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@Taym95 Taym95 requested a review from Esemesek May 6, 2019 12:33
@@ -6,6 +6,7 @@ export interface ModalProps {
onDismiss?: () => any;
visible: boolean;
children: React.ReactNode;
contentContainerStyle?: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change it to StyleProp<ViewStyle>?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to import the types from react-native

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, My bad sorry!

@ferrannp ferrannp merged commit ff15100 into callstack:master May 9, 2019
@vko-online
Copy link

not published yet :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contentContainerStyle property to ModalProps interface
5 participants