fix: correct Chip component typings #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of version 2.15.2 the Chip component accepts the prop `selectedColor` which it defines as an optional string prop. Though this change was introduced to the Chip component itself, the typings for the component were not updated which causes Typescript to complain when using the `selectedColor` prop. This change adds the missing type to appease Typescript.
|
Hey @mikestone14, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API. |
|
cc @lukewalczak since it looks like you added the prop initially. |
Trancever
approved these changes
May 2, 2019
iyadthayyil
pushed a commit
to iyadthayyil/react-native-paper
that referenced
this pull request
Jun 6, 2019
As of version 2.15.2 the Chip component accepts the prop `selectedColor` which it defines as an optional string prop. Though this change was introduced to the Chip component itself, the typings for the component were not updated which causes Typescript to complain when using the `selectedColor` prop. This change adds the missing type to appease Typescript.
Trancever
pushed a commit
that referenced
this pull request
Jun 27, 2019
As of version 2.15.2 the Chip component accepts the prop `selectedColor` which it defines as an optional string prop. Though this change was introduced to the Chip component itself, the typings for the component were not updated which causes Typescript to complain when using the `selectedColor` prop. This change adds the missing type to appease Typescript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As of version 2.15.2 the Chip component accepts the prop
selectedColorwhich it defines as an optional string prop. Though this change was
introduced to the Chip component itself, the typings for the component
were not updated which causes Typescript to complain when using the
selectedColorprop. This change adds the missing type to appeaseTypescript.
Test plan
The change to
__ts-tests__/Chip.test.tsxexposes the issue described in the "Motivation" section. Tests pass with the change totypings/components/Chip.d.tsand fail without them. There are no visual changes associated with this change.