Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom style input applied to label in TextInput component #3648

Closed
tjaniczek opened this issue Feb 2, 2023 · 0 comments · Fixed by #3649
Closed

Custom style input applied to label in TextInput component #3648

tjaniczek opened this issue Feb 2, 2023 · 0 comments · Fixed by #3649
Assignees
@tjaniczek
Labels
bug TextInput

Comments

@tjaniczek
Copy link
Collaborator

Current behaviour

Custom style is applied to both input and the label, which looks like a bug

Expected behaviour

Custom style should be applied to input only, keeping default label styling

How to reproduce?

Click on/off on Custom style input in the example app. This is more visible if custom styling has more styles applied than padding only.

Preview

Screen.Recording.2023-02-02.at.14.23.58.mov

Your Environment

software version
ios 16.2
android 13
react-native 0.70.6
react-native-paper 5.1.4
node 16.19.0
yarn 1.22.19
expo sdk 6.1.0
@tjaniczek tjaniczek added the bug label Feb 2, 2023
@tjaniczek tjaniczek self-assigned this Feb 2, 2023
tjaniczek pushed a commit that referenced this issue Feb 2, 2023
fix: custom input styling in TextInput (#3648)
45c974d
@tjaniczek tjaniczek mentioned this issue Feb 2, 2023
Merged
tjaniczek pushed a commit that referenced this issue Feb 6, 2023
fix: custom input styling in TextInput (#3648)
118200c
lukewalczak pushed a commit that referenced this issue Feb 6, 2023
@tjaniczek
fix: custom input styling in TextInput (#3648) (#3649)
e4c2e9d
tjaniczek added a commit that referenced this issue Feb 7, 2023
@tjaniczek
refactor: fix performance of TextInput by memoizing InputLabel (#3648) (
4e281a5 
#3649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjaniczek tjaniczek

Labels
bug TextInput
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: custom input styling in TextInput (#3648) callstack/react-native-paper
1 participant
@tjaniczek