Remove comments, add type for RenderProps in TextInput

callstack · Mar 18, 2019 · 7a905e7 · 7a905e7
1 parent 7541121
commit 7a905e7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/components/TextInput/TextInput.js b/src/components/TextInput/TextInput.js
@@ -7,7 +7,7 @@ import { polyfill } from 'react-lifecycles-compat';
 import TextInputOutlined from './TextInputOutlined';
 import TextInputFlat from './TextInputFlat';
 import { withTheme } from '../../core/theming';
-import type { Props } from './types';
+import type { Props, RenderProps } from './types';
 
 type TextInputProps = {|
  ...Props,
@@ -78,7 +78,7 @@ class TextInput extends React.Component<TextInputProps, State> {
  error: false,
  multiline: false,
  editable: true,
- render: props => <NativeTextInput {...props} />,
+ render: (props: RenderProps) => <NativeTextInput {...props} />,
  };
 
  render() {

diff --git a/src/components/TextInput/TextInputFlat.js b/src/components/TextInput/TextInputFlat.js
@@ -325,7 +325,6 @@ class TextInputFlat extends React.Component<Props, State> {
 
  return (
  <View style={[containerStyle, style]}>
- {/* When mode === 'flat', render an underline */}
  <Animated.View
  style={[
  styles.underline,

diff --git a/src/components/TextInput/TextInputOutlined.js b/src/components/TextInput/TextInputOutlined.js
@@ -333,7 +333,7 @@ class TextInputOutlined extends React.Component<Props, State> {
  />
 
  {label ? (
- // When mode == 'outlined', the input label stays on top of the outline
+ // The input label stays on top of the outline
  // The background of the label covers the outline so it looks cut off
  // To achieve the effect, we position the actual label with a background on top of it
  // We set the color of the text to transparent so only the background is visible