Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux support #6

Merged
merged 7 commits into from
Mar 9, 2021
Merged

linux support #6

merged 7 commits into from
Mar 9, 2021

Conversation

nkruzan
Copy link
Contributor

@nkruzan nkruzan commented Feb 7, 2021

would it be preferred to break out instructions like this or just mix linux examples in

@calebmarting
Copy link
Owner

would it be preferred to break out instructions like this or just mix linux examples in

I think breaking it out makes the most sense. In the actual makefiles and stuff we should try to make it detect OS and run the correct commands.

@nkruzan
Copy link
Contributor Author

nkruzan commented Feb 19, 2021

still compatibility issues

@nkruzan
Copy link
Contributor Author

nkruzan commented Feb 19, 2021

i also had to modify BlueNRG1.h and system_bluenrg1.c due to case-sensitivity. not sure best way to handle that

@jmrharris
Copy link

Hi @nkruzan - I just grabbed the Makefile from your fork, updated the incorrectly cased filenames in the ST library, and it built first go! Thanks.

@nkruzan nkruzan marked this pull request as ready for review February 27, 2021 03:23
@nkruzan
Copy link
Contributor Author

nkruzan commented Feb 27, 2021

Hi @nkruzan - I just grabbed the Makefile from your fork, updated the incorrectly cased filenames in the ST library, and it built first go! Thanks.

Thanks for the feedback, I have marked for review, but I am sure there is room for improvement.

@calebmarting calebmarting merged commit 676d2da into calebmarting:main Mar 9, 2021
@nkruzan nkruzan deleted the patch-2 branch September 1, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants