dockerfile: build wheel in container #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
requested review from
alex-jw-brooks,
gkumbhat,
evaline-ju,
gabe-l-hart and
tharapalanivel
as code owners
dtrifiro
force-pushed
the
improve-dockerfile
branch
from
31b6d21
to
80b6e32
Compare
Dockerfile was consuming a previously built wheel because setuptools_scm requires access to the git repository. By mounting the `.git` directory at the build step, we can build the wheel in the container. Signed-off-by: Daniele Trifirò <[email protected]>
dtrifiro
changed the title
Xaenalt
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile was consuming a previously built wheel because setuptools_scm requires access to the git repository. By mounting the
.gitdirectory at the build step, we can build in the container.