Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧑‍💻 Improve regex for directory validation #275

Merged
merged 3 commits into from
Nov 27, 2023
Merged

🧑‍💻 Improve regex for directory validation #275

merged 3 commits into from
Nov 27, 2023

Conversation

gkumbhat
Copy link
Collaborator

Changes

  • Update directory validation to account for models having . in their name

tharapalanivel
tharapalanivel approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@tharapalanivel tharapalanivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we do need to get back to that regex fix soon though. thanks Gaurav!

@gkumbhat gkumbhat merged commit 3ff5c28 into caikit:main Nov 27, 2023
5 checks passed
@gkumbhat gkumbhat deleted the enhance_dir_val_regex branch November 27, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tharapalanivel tharapalanivel tharapalanivel approved these changes

@alex-jw-brooks alex-jw-brooks Awaiting requested review from alex-jw-brooks alex-jw-brooks is a code owner

@evaline-ju evaline-ju Awaiting requested review from evaline-ju evaline-ju is a code owner

@gabe-l-hart gabe-l-hart Awaiting requested review from gabe-l-hart gabe-l-hart is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkumbhat @tharapalanivel