Text Embedding: Add optimizations with PT2_COMPILE and/or IPEX #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: markstur <[email protected]>
Signed-off-by: markstur <[email protected]>
evaline-ju
reviewed
Nov 28, 2023
* Was not very testable * Refactored into testable pieces * Added tests * Pretty good coverage of env toggles using monkeypatch * Still not requiring (or mocking) the optional libraries Signed-off-by: markstur <[email protected]>
Yep. The way it was written, I just didn't think unit tests made sense (which I know obviously meant it was written wrong). So I refactored and added tests to cover most of the code. Not mocking the actual optimize or compile at this point, but enough tests to get through those decision branches with monkeypatch env var fixtures. Also added one line to "warmup" the model. |
|
I forgot the "mps" test will only work on a Mac GPU. Fix coming asap. Thanks! |
MPS only works on Mac GPU. Add tests to tests. Signed-off-by: markstur <[email protected]>
Signed-off-by: markstur <[email protected]>
* undo the MPS conditional that was not needed Signed-off-by: markstur <[email protected]>
evaline-ju
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag to use pytorch compile and/or try IPEX.
To use IPEX:
Default is false. If set to true, but the import fails, then a warning will be logged and USE_IPEX will be disabled.
Optionally, USE_XPU may be set to true to allow IPEX to use its xpu (only applies when IPEX is active).
USE_MPS has been added for GPU testing on Macbook (ignored when IPEX is used).
To invoke torch.compile() optimization, set the env var PT2_COMPILE=true.
torch.compile() is not available on all versions/platforms. A warning message is logged if this is enabled and throws an exception.