Add data limitation #255
Merged
Add data limitation #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkumbhat
requested review from
alex-jw-brooks,
evaline-ju,
gabe-l-hart and
tharapalanivel
as code owners
evaline-ju
reviewed
Nov 1, 2023
| if max_num_examples > 0: | ||
| error.value_check( | ||
| "<NLP77627434E>", | ||
| len(train_stream) <= max_num_examples, |
There was a problem hiding this comment.
We'll probably need to make sure a release with caikit/caikit#553 is made and bumped here to make sure we don't run into the same len problem as #223?
There was a problem hiding this comment.
yep, thats definitely required
| max_num_examples = get_config().training_data_limit.get(cls.MODULE_ID, {}).get(base_model_name, -1) | ||
|
|
||
| if max_num_examples > 0: | ||
| error.value_check( |
There was a problem hiding this comment.
maybe good to have a tiny unit test case with temp config? :)
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
gkumbhat
force-pushed
the
add_data_limitation
branch
from
6c0c249
to
7c79e18
Compare
evaline-ju
approved these changes
Nov 1, 2023
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
Closed
Signed-off-by: gkumbhat <[email protected]>
Signed-off-by: gkumbhat <[email protected]>
evaline-ju
reviewed
Nov 2, 2023
| @@ -14,7 +14,7 @@ classifiers=[ | |||
| "License :: OSI Approved :: Apache Software License" | |||
| ] | |||
| dependencies = [ | |||
| "caikit[runtime-grpc,runtime-http]>=0.22.0,<0.23.0", | |||
| "caikit[runtime-grpc,runtime-http]>=0.23.2,<0.25.0", | |||
There was a problem hiding this comment.
I suppose chances can be taken that 0.24 won't be breaking for this library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description