Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up tests #249

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Speed up tests #249

merged 1 commit into from
Oct 31, 2023

Conversation

dtrifiro
Copy link
Contributor

By using the connect_timeout configuration option implemented in caikit/caikit-tgis-backend#40, test_bad_tgis_connection takes 5s instead of 78s (see #246)

$ pytest --durations=5 tests/model_management/test_tgis_auto_finder.py::test_bad_tgis_connection
============================================================================ test session starts =============================================================================
platform linux -- Python 3.11.5, pytest-7.4.2, pluggy-1.3.0
rootdir: caikit-nlp
plugins: anyio-3.7.1, metadata-3.0.0, cov-4.1.0, html-4.0.2
collected 1 item

tests/model_management/test_tgis_auto_finder.py .                                                                                                                      [100%]

============================================================================ slowest 5 durations =============================================================================
5.01s call     tests/model_management/test_tgis_auto_finder.py::test_bad_tgis_connection

(2 durations < 0.005s hidden.  Use -vv to show these durations.)
============================================================================= 1 passed in 7.54s =============================================================================

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Oct 27, 2023

Copy link
Collaborator

@gkumbhat gkumbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 thanks for the fix.

@gkumbhat gkumbhat merged commit bb02505 into caikit:main Oct 31, 2023
4 checks passed
@dtrifiro

This comment was marked as outdated.

@dtrifiro dtrifiro deleted the speed-up-tests branch October 31, 2023 15:57
@evaline-ju
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants