Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tgis auto finder #123

Merged
merged 13 commits into from
Aug 10, 2023
Merged

Tgis auto finder #123

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1fde8f5
TgisAutoFinder: Initial implementation of TGISAutoFinder
gabe-l-hart Aug 4, 2023
a92d7d9
TgisAutoFinder: Add remote_tgis finder to runtime_config
gabe-l-hart Aug 4, 2023
c9608d3
TgisAutoFinder: Remove connection test
gabe-l-hart Aug 8, 2023
666066d
TgisAutoFinder: Bug fixes in value checks
gabe-l-hart Aug 8, 2023
4b587c6
TgisAutoFinder: Add the ability to give a specific TGIS backend to us…
gabe-l-hart Aug 8, 2023
54b7a69
TgisAutoFinder: Skip peft training tests on arm processors
gabe-l-hart Aug 8, 2023
5962280
TgisAutoFinder: Happy path unit tests for the auto finder
gabe-l-hart Aug 8, 2023
ca43fc7
TgisAutoFinder: Bump caikit to allow 0.15
gabe-l-hart Aug 8, 2023
459a375
TgisAutoFinder: Don't require instance_name in finder constructor
gabe-l-hart Aug 9, 2023
5893a4a
TgisAutoFinder: Bump caikit-tgis-backend for connection testing
gabe-l-hart Aug 9, 2023
ad68f91
TgisAutoFinder: Add model_id in mock TGISConnection
gabe-l-hart Aug 9, 2023
16929b3
TgisAutoFinder: Handle bad tgis connections
gabe-l-hart Aug 9, 2023
08b202b
TgisAutoFinder: Linting fixes
gabe-l-hart Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TgisAutoFinder: Don't require instance_name in finder constructor 
This is there to meet the factory abstract interface, but it's not used so
if someone ever did want to create an instance manually (which is a valid
usecase when using `caikit.load` directly), we don't want to require it.

Signed-off-by: Gabe Goodhart <[email protected]>
  • Loading branch information
@gabe-l-hart
gabe-l-hart committed Aug 9, 2023
commit 459a3750b99566c2367bb4622922c7072103787e
2 changes: 1 addition & 1 deletion caikit_nlp/model_management/tgis_auto_finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class TGISAutoFinder(ModelFinderBase):
_LOCAL_INITIALIZER_NAME_KEY = "local_initializer_name"
_TGIS_BACKEND_PRIORITY_KEY = "tgis_backend_priority"

def __init__(self, config: aconfig.Config, instance_name: str):
def __init__(self, config: aconfig.Config, instance_name: str = ""):
"""Initialize from the model finder factory config

Config schema:
Expand Down