Skip to content

v70

Pre-release
Pre-release
Compare
Choose a tag to compare
@Xaymar Xaymar released this 22 Apr 18:41
· 0 commits to caffeine since this release
Deliver partial SCTP messages when the SID is (unexpectedly) changed.

We're receiving SCTP messages one chunk at a time. The sender is supposed to set the MSG_EOR bit on the last chunk of a message. A crash (RTC_CHECK) happened when the sender started a new message without indicating the end of the previous message. This is likely due to an SCTP implementation that doesn't (correctly) support the MSG_EOR bit.

This change, rather than calling RTC_CHECK, delivers partial messages when SID is (unexpectedly) changed, which is what happened before we paid attention to the MSG_EOR bit ourselves.

[email protected]

(cherry picked from commit ad5465b443cc5fda563dca4b40e52580e14cb621)

Bug: chromium:884926
Change-Id: I18c773bb60ae724b735a83933eedd030f6360a3c
Reviewed-on: https://webrtc-review.googlesource.com/c/103023
Commit-Queue: Jeroen de Borst <[email protected]>
Reviewed-by: Steve Anton <[email protected]>
Reviewed-by: Qingsi Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#24935}
Reviewed-on: https://webrtc-review.googlesource.com/c/106145
Reviewed-by: Jeroen de Borst <[email protected]>
Cr-Commit-Position: refs/branch-heads/70@{#17}
Cr-Branched-From: f18b35284288ac851b77db88df3e2e8d2273db97-refs/heads/master@{#24472}