Add readiness check for memcached #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenonameguy
suggested changes
Jun 2, 2023
src/modules/services/memcached.nix
Outdated
| process-compose = { | ||
| readiness_probe = { | ||
| exec.command = '' | ||
| ${pkgs.bash}/bin/bash -c 'exec 3<>/dev/tcp/${cfg.bind}/${toString cfg.port}; printf "stats\nquit\n" >&3; cat <&3' |
There was a problem hiding this comment.
On *nix-es process-compose already executes the commands via bash, so no need for the extra process.
There was a problem hiding this comment.
Thanks, I didn't realize that. While I was at it, I added memcached to the process-compose example so that it's available to see the readiness probe.
penguincoder
force-pushed
the
memcached-readiness-check
branch
from
2cda771
to
a349892
Compare
thenonameguy
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple bash-based readiness check. It will fail if the server is faulted for whatever reason. I chose
bashoverncbecause it is fairly prevalent throughout all ofnixpkgsand you are likely to have it already loaded in your store.