Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using
IdMapper
because it can't map two ids to the same block. This should never happen but apparently Minecraft doesn't care about Mojang fixing bugs.I also made
GlobalPalette
a special case because not usingIdMapper
anymore means we'd have to copy the entire registry in order to avoid the special case and there is a huge speed difference between scanning all blockstate ids for a handful of states vs. looking up the ids of those states in a hash map.Should fix #3917