add: test code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 27, 2023 17:34
gassara-kys
commented
Jan 11, 2024
| } | ||
|
|
||
| func osCmdInjection(userInput string) error { | ||
| cmd := exec.Command(userInput) // OS command injection |
There was a problem hiding this comment.
問題のコードを発見しました。修正が必要か確認してください🙏
コードスキャン結果
- Semgrep CheckID:
go.lang.security.audit.dangerous-exec-command.dangerous-exec-command - 説明:
Detected non-static command inside Command. Audit the input to 'exec.Command'. If unverified user data can reach this call site, this is a code injection vulnerability. A malicious actor can inject a malicious script to execute arbitrary code.
RISKENで確認
より詳細な情報や生成AIによる解説はRISKENコンソール上で確認できます。
By RISKEN review
gassara-kys
commented
Jan 11, 2024
| } | ||
|
|
||
| const ( | ||
| TEST_SECRET_KEY = "AKIAIMNOJVGFDXXXE4OA" // aws test key. https://github.com/gitleaks/gitleaks |
There was a problem hiding this comment.
シークレット情報が含まれている可能性があります👀
シークレットスキャン結果
- シークレットタイプ: AWS
- 説明:
対象データがテスト用のダミーデータや公開可能な情報であるか確認してください。
もし、有効なシークレット情報の場合はキーのローテーションや権限の削除（キーの無効化）を行ってください。
どうしてもシークレット情報をコミットする必要がある場合は、プライベートリポジトリになっていることを確認しアクセスできる人を限定してください。
RISKENで確認
より詳細な情報や生成AIによる解説はRISKENコンソール上で確認できます。
By RISKEN review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is test PR.