tidb_query_vec_executors: Fixed stack-borrowing undefined-behavior (t…

…ikv#7709) Signed-off-by: Brian Anderson <[email protected]>
c1ay · May 9, 2020 · b00adbc · b00adbc
1 parent 7f13c4d
commit b00adbc
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/components/tidb_query_vec_executors/src/slow_hash_aggr_executor.rs b/components/tidb_query_vec_executors/src/slow_hash_aggr_executor.rs
@@ -277,7 +277,6 @@ impl<Src: BatchExecutor> AggregationExecutorImpl<Src> for SlowHashAggregationImp
  )?;
  }
 
- let buffer_ptr = (&*self.group_key_buffer).into();
  for logical_row_idx in 0..logical_rows_len {
  let offset_begin = self.group_key_buffer.len();
 
@@ -361,6 +360,7 @@ impl<Src: BatchExecutor> AggregationExecutorImpl<Src> for SlowHashAggregationImp
  }
  }
 
+ let buffer_ptr = (&*self.group_key_buffer).into();
  // Extra column is not included in `GroupKeyRefUnsafe` to avoid being aggr on.
  let group_key_ref_unsafe = GroupKeyRefUnsafe {
  buffer_ptr,