Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a wasmparser -> wasm-encoder trait #1628

Merged
merged 15 commits into from
Jun 25, 2024
Merged

Implement a wasmparser -> wasm-encoder trait #1628

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
913c34b
Implement a reencoder helper trait
juntyr Jun 21, 2024
ab5d2dc
Use new error type in all conversions
juntyr Jun 21, 2024
2611ca9
Centralise from impls
juntyr Jun 21, 2024
7bf6d37
Remove mut ref returns
juntyr Jun 21, 2024
5908bcf
rename trait
juntyr Jun 21, 2024
a9538cc
reencode the data count section
juntyr Jun 21, 2024
bac264d
refactor core module parsing helper
juntyr Jun 21, 2024
71acc16
Add some more docs
juntyr Jun 21, 2024
663ae4a
reorder trait members
juntyr Jun 21, 2024
59d37fc
Review comments plus a reencoder fuzzer
alexcrichton Jun 21, 2024
59b402b
Use `Reencode` in `wit-component`
alexcrichton Jun 22, 2024
3a74697
Add user error variant
juntyr Jun 22, 2024
645d835
Fix Reencode impl
juntyr Jun 22, 2024
b636479
Add an intersperse section hook to allow more complex user module bui…
juntyr Jun 22, 2024
90d114d
Add docs to section intersperse hook
juntyr Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Reencode impl
  • Loading branch information
@juntyr
juntyr committed Jun 25, 2024
commit 645d835929d919b3815e1056df2b8f6ec88d8cc5
3 changes: 3 additions & 0 deletions crates/wit-component/src/gc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use indexmap::{IndexMap, IndexSet};
use std::{
borrow::Cow,
collections::{HashMap, HashSet},
convert::Infallible,
mem,
ops::Deref,
};
Expand Down Expand Up @@ -1054,6 +1055,8 @@ struct Encoder {
}

impl Reencode for Encoder {
type Error = Infallible;

fn type_index(&mut self, i: u32) -> u32 {
self.types.remap(i)
}
Expand Down