Fix panic on dropping RecvAncillaryBuffer
after failed recvmsg
#676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling drain on
RecvAncillaryBuffer
, including in itsDrop
implementation was failing, with an "attempted to subtract with overflow" error incvt_msg
.If
recvmsg
returns-1
,msg_controllen
will not be updated by the call. So it had a non-zero value as passed into the function, despite there not being any control messages to parse.