Fix the fstat/statat/etc. fallback when statx fails with EPERM. #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some old non-y2038-safe container runtimes, `statx` fails with `EPERM`, so use `crate::fs::statx` instead of calling the statx syscall directly. This includes code to check whether it was a "real" `EPERM` we should return to the user, or an `EPERM` which indicates that statx isn't supported, allowing rustix to fall back to the old non-y2038-safe syscalls. Also, update the crate-level comment mentionintg that rustix does sometimes do dynamic feature detection in order to support y2038 and LFS. And fix a copy and paste in a comment in `renameat2`.
a1ee9b6
to
067a113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some old non-y2038-safe container runtimes,
statxfails withEPERM, so usecrate::fs::statxinstead of calling the statx syscall directly. This includes code to check whether it was a "real"EPERMwe should return to the user, or anEPERMwhich indicates that statx isn't supported, allowing rustix to fall back to the old non-y2038-safe syscalls.Also, update the crate-level comment mentionintg that rustix does sometimes do dynamic feature detection in order to support y2038 and LFS.
And fix a copy and paste in a comment in
renameat2.