Issue 245 turn echo off on each exec #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the echo status to OFF on each example execution. This helps to reduce the need of an active echo-filtering at the expense of some additional overhead. Because this could break users' examples (very unlikely), we set this to False by default (no turn off is done) and we delay the default to True (turn the echo off) for byexample 11.0.0
… is introduced (may break) The -x-turn-echo-off flag introduced in 10.5.4, disabled by default, is enabled (set to True) by default on 11.0.0. This may break existing examples if they relay on the echo *not* being filtered. To reduce the impact of the change, if force-echo-filtering is on, the -x-turn-echo-off has no effect. Cases where force-echo-filtering is off and still the echo is required are very unlikely (but docs/advanced/echo-filtering.md is on example). We add -x-turn-echo-off-on-spawn flag (True by default) to control the echo filtering at the spawn of a runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245