Add missing webhook thread endpoints and allow overriding webhook message attachments #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for implementing these missing features, however, I think it's a good idea to separate the endpoint and attachment changes into different PRs, since they have completely different scopes. |
|
#1392 adds the attachments parameter so I will remove it from this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
attachmentsfield to theWebhookEditstruct so you can remove and override attachments on webhook messages. See https://discord.com/developers/docs/resources/webhook#edit-webhook-messageIt also adds the missing thread specific equivalents to the
WebhookMessage,WebhookMessageEdit, andWebhookMessageDeleteendpoints.