Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to specify assets as remote URLs #3

Open
burtonageo opened this issue Jun 6, 2016 · 1 comment
Open

It should be possible to specify assets as remote URLs #3

burtonageo opened this issue Jun 6, 2016 · 1 comment

Comments

@burtonageo
Copy link
Owner

In the Bundle.toml file, it should be possible to have assets specified as a url, and then cargo bundle should download them. Bonus: support for remote repositories

@mdsteele
Copy link
Collaborator

mdsteele commented Sep 4, 2017

I think each remote resource entry will probably need multiple attributes: URL, file checksum, repo tag/commit, etc. So each of these entries will need to be a toml table, not just a simple string, so they probably can't be part of the resources attribute, which is just an array of strings.

One option would be to add a new top-level attribute called remote-resources or something, which can be an array of tables (or table of tables), and leave resources as a simple array of strings.

Another option would be to just have resources, but make it a table rather than an array, and have it be like the [dependencies] section of Cargo.toml -- each resource file/directory has a key, and the value can either be a string filepath, or a sub-table with url/checksum/etc. However, that would be a breaking change, and seems a little more annoying for the (common?) case where there are no remote resources.

Not sure what's best. Probably there are other options too.

mdsteele pushed a commit that referenced this issue May 6, 2023
Resolve the conflicts and merge the master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants