Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation #4118

Merged
merged 1 commit into from
May 27, 2022
Merged

Fix indentation #4118

merged 1 commit into from
May 27, 2022

Conversation

dbartolini
Copy link
Contributor

No description provided.

akien-mga
akien-mga approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to PR the same, the fix is correct. Here's an example warning with Emscripten:

error: field 'm_normalWorldOnB' will be initialized after field 'm_positionWorldOnB' [-Werror,-Wreorder-ctor]

I'd suggest also fixing indentation of m_lateralFrictionDir{1,2} while at it which were also added recently with space indentation instead of tabs.

@dbartolini
Copy link
Contributor Author

Updated with indentation fix.

@dbartolini
Copy link
Contributor Author

Rebased with indentation fix only.

@dbartolini dbartolini changed the title Fix warning with -Wreorder on GCC Fix indentation Mar 28, 2022
@erwincoumans
Copy link
Member

thanks, LGTM.

@erwincoumans erwincoumans merged commit a1d9664 into bulletphysics:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbartolini @erwincoumans @akien-mga