System for reporting warnings (soft errors) #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UnknownStep
, and where a pipeline is parsed with no steps.Background
We have some cases in the parser where, when a failure occurs, parsing continues but producing a pipeline with lower semantic information:
There may be other reasons. These all boil down to "this package is not the authoritative specification for pipeline YAML".
However, silently dropping errors is not great, when they could be used to diagnose why a pipeline isn't being interpreted correctly. Without vigilance, it's easy to write YAML that looks like one thing but is parsed as another. For example:
will not parse correctly because
env
block requires strings for values, yet the inline JSON will be parsed as a mapping (this is true here and on the backend)!
has special meaning in YAML when not quoted, so it will end up withbranches: ''