Upgrade gorm clickhouse driver and remove patch #3757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
maggie-lou
requested review from
luluz66,
iain-macdonald,
siggisim and
bduffany
siggisim
approved these changes
Apr 12, 2023
maggie-lou
force-pushed
the
upgrade_gorm_clickhouse
branch
from
3fabe72
to
082e442
Compare
|
Realized that the gorm-clickhouse recently upgraded a bunch of its dependencies, like gorm. Going to punt on upgrading this for now, because we don't need to and it doesn't feel worth the risk to change a lot of our dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR was merged to master, so we no longer need a patch: go-gorm/clickhouse#91 (comment)