Updated breadcrumb clamp #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardelms
previously requested changes
Apr 25, 2023
Co-authored-by: Tom Longridge <[email protected]>
tomlongridge
approved these changes
Jun 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In the v5.28.0 of the android notifier we upped the max breadcrumbs to 500. The unreal notifier was bumped to use this dependency in v1.5.1. With this android update we should allow for a max of 500 breadcrumbs on events in unreal
Changeset
maxbreadcrumbs clamp was upped from 100 - 500
Testing
Set plugin breadcrumbs value to 500 in the editor and then sent 500 breadcrumbs in an event to the dashboard. all breadcrumbs correctly set in dashboard