[PLAT-8394] Fix crash in minified Android builds #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d140a2
to
32763d6
Compare
kattrali
approved these changes
Apr 26, 2022
| @@ -21,14 +21,14 @@ | |||
|
|
|||
| <gameActivityClassAdditions> | |||
| <insert> | |||
| private void clearBugsnagCache() { | |||
| public void clearBugsnagCache() { | |||
There was a problem hiding this comment.
ProGuard seems to hide private methods, making them unaccessible from JNI.
There was a problem hiding this comment.
Hmm. So this is simpler than adding it to the app's proguard rules. Ok 👍
There was a problem hiding this comment.
Yes it seemed simpler to make these public than adding more proguard rules 🙃
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix a crash in Bugsnag when used in Android apps that are built for distribution, with the following log messages:
Changeset
Adds a ProGuard rule (via UPL) to prevent
com.bugsnag.**Java classes being obfuscated.Makes the test fixture's
gameActivityClassAdditionsmethods public so that they are not hidden by ProGuard.Testing
Updates build files to produce Distribution (minified) and signed builds for example app & test fixture. This reproduces the crash and causes E2E testing to fail - e.g. https://buildkite.com/bugsnag/bugsnag-unreal/builds/1014
E2E tests pass with the fix in place.