added support for monorepo #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y we retrieve always the right package location
This was referenced Aug 30, 2023
clr182
added
feature request
|
Hi @ricardoribas |
|
Thanks a lot @clr182. As this is my very first PR to a library, let me if there is anything I could do to improve. |
|
@clr182 do you have any update on this? |
|
We appreciate your patience here. Unfortunately we don't have any updates on an ETA yet, but this remains on our backlog to be looked at when priorities allow. We will make sure to post any updates here when they are available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When we setup bugsnag react native package, it doesn't support 100% monorepo. Apparently, the best option right now to support that is to perform hoisting on packages (if you are using yarn workspaces). The idea is to support a standalone package, but also monorepo.
Design
To better locate the bugsnag sourcemap package. When executing under the xcode build phases, the relative path will not work if we are working under monorepo projects. With this approach, the problem gets solved.
Changeset
Changed binary in order to target the right package location
Testing
Right now i just tested on my project. I would need some guidance in order to test it properly and not affect other developers. Feedback is needed 😄