Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log that can be excessively noisy #40

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

imjoehaines
Copy link
Member

Goal

In RAM bundles there can be many sub-source maps, each of which result in a log message when the sourcesContent is present

Consola squishes these together for us (see source) but it's still quite noisy before we hit the threshold and we could be logging hundreds of messages if the user provides a custom logger

I opted not to add another log for when we are adding sourcesContent because there doesn't seem to be anything useful that's unique — the file path is shared between every sub-source map, so we would end up with the same problem if sourcesContent was missing

@imjoehaines imjoehaines merged commit 0d35e28 into next Dec 7, 2020
@imjoehaines imjoehaines deleted the remove-excessive-log branch December 7, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants