Allow ".bundle" extension for entry point files #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
approved these changes
Dec 7, 2020
imjoehaines
force-pushed
the
allow-bundle-file-extension
branch
from
ae5ed6c
to
904e144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
There was some confusion in testing with the
--bundler-entry-pointoption — this is intended to be a file (i.e. "index.js" in most cases) that we request the bundle for but a user was providing the bundle file name instead (i.e. "index.bundle")This PR adds the word "file" to the option help text, so hopefully it's a bit clearer and allows the ".bundle" extension as well