Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error when app version cannot be detected #34

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Improve error when app version cannot be detected #34

merged 1 commit into from
Dec 4, 2020

Conversation

imjoehaines
Copy link
Member

Goal

Currently this fails when sending the request with a generic error — Not enough options supplied

With this PR, the error will be:

Unable to automatically detect app version. Provide the "--app-version" argument or add a "version" key to your package.json file.

@imjoehaines
Improve error when app version cannot be detected
ac87698 
Currently this fails when sending the request with a generic error
@imjoehaines imjoehaines marked this pull request as ready for review December 4, 2020 16:47
@imjoehaines imjoehaines merged commit 593a385 into next Dec 4, 2020
@imjoehaines imjoehaines deleted the better-error-for-no-app-version branch December 4, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imjoehaines @bengourley