Allow absolute paths in the --directory option
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The intention of
--directorywas to be a path to a directory within the project root, but this is a bit unclear. Using an absolute path doesn't work because the directory and project root are concatenated, which will never result in a valid pathThis now uses
path.resolveto ensure that an absolute--directorywill be used as-isThe request unit tests were flaking on CI (example) so I increased the timeout from 100ms to 250ms
Testing
Unit tested by duplicating the relative path
--directorytests but switching them to absolute paths and added MR tests