Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plat 10223 deterministic device ids #1568

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

kstenerud
Copy link
Contributor

@kstenerud kstenerud commented Jun 27, 2023

Goal

Implement the same persistent device ID code as was implemented in bugsnag-cocoa-performance.

As bugsnag-cocoa uses two device IDs (one for internal bugsnag events), the code has been expanded to save both values (and this change is being backported to bugsnag/bugsnag-cocoa-performance#177).

As a result, both bugsnag-cocoa and bugsnag-cocoa-performance will store the exact same information in this shared file.

Testing

Added unit tests to confirm the structure and location of the shared persistent device ID file.

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Bugsnag.framework binary size increased by 5,400 bytes from 707,904 to 713,304

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.6% +3.75Ki  +1.6% +3.75Ki    __TEXT,__text
  +1.9% +3.01Ki  +1.9% +3.01Ki    String Table
  +1.8% +2.25Ki  +1.8% +2.25Ki    Symbol Table
  +1.7%    +648  +1.7%    +648    __DATA,__objc_const
  +1.3%    +239  +1.3%    +239    __TEXT,__objc_methname
  +4.8%    +160  +4.8%    +160    __DATA,__objc_data
  +0.6%    +128  +0.6%    +128    __DATA,__cfstring
  +3.1%     +96  +3.1%     +96    __DATA,__const
  +2.3%     +80  +2.3%     +80    [Mach-O Headers]
  +0.3%     +60  +0.3%     +60    __TEXT,__cstring
  +1.2%     +56  +1.2%     +56    __DATA,__objc_selrefs
  +1.7%     +52  +1.7%     +52    __TEXT,__unwind_info
  +1.4%     +40  +1.4%     +40    Binding Info
  +2.3%     +40  +2.3%     +40    Rebase Info
  +0.1%      +8  +0.2%     +40    [11 Others]
  +3.5%     +36  +3.5%     +36    __TEXT,__objc_classname
  -1.7%     -36  -1.7%     -36    __TEXT,__stub_helper
  -1.7%     -72  -1.7%     -72    Lazy Binding Info
 -13.9% -1.11Ki  -7.9% -1.14Ki    [__DATA]
 -17.9% -4.12Ki -17.9% -4.12Ki    [__TEXT]
  [ = ]       0 -41.6% -5.27Ki    [__LINKEDIT]
  +0.8% +5.27Ki  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud changed the base branch from master to next June 27, 2023 14:14
@kstenerud kstenerud force-pushed the PLAT-10223-deterministic-device-ids branch 2 times, most recently from e71c8ef to 05e3a36 Compare June 27, 2023 14:25
@kstenerud kstenerud merged commit 8891bff into next Jun 29, 2023
36 checks passed
@kstenerud kstenerud deleted the PLAT-10223-deterministic-device-ids branch June 29, 2023 10:05
This was referenced Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants