Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable breadcrumb disk storage when not required #1534

Conversation

robert-smartbear
Copy link
Contributor

Goal

Breadcrumbs are currently stored on disk so that they can be included in OOM and Thermal Kill events.

If these event types are disabled or not supported on the target platform, storage should be disabled to reduce overhead.

Seems particularly important on watchOS.

Changeset

Disable breadcrumb disk storage when not required

Testing

Unit tests

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Bugsnag.framework binary size increased by 184 bytes from 706,776 to 706,960

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +236  +0.1%    +236    __TEXT,__text
  +0.1%     +96  +0.1%     +96    String Table
  +0.1%     +80  +0.1%     +80    Symbol Table
  +0.5%      +8  +0.5%      +8    Function Start Addresses
  +0.1%      +4  +0.1%      +4    __TEXT,__unwind_info
  [ = ]       0  -1.3%    -184    [__LINKEDIT]
  -1.0%    -240  -1.0%    -240    [__TEXT]
  +0.0%    +184  [ = ]       0    TOTAL

Generated by 🚫 Danger

@robert-smartbear robert-smartbear merged commit 9eee6d7 into next Mar 10, 2023
@robert-smartbear robert-smartbear deleted the robert/plat-8339-disable-breadcrumb-storage-when-not-required branch March 10, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants