Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Monolog/Interfaces/TCP/Service need to check message is really json #86

Closed
gam6itko opened this issue Nov 8, 2023 · 0 comments · Fixed by #90
Closed

🐛 Monolog/Interfaces/TCP/Service need to check message is really json #86

gam6itko opened this issue Nov 8, 2023 · 0 comments · Fixed by #90

Comments

@gam6itko
Copy link

gam6itko commented Nov 8, 2023

server/app/modules/Monolog/Interfaces/TCP/Service.php

Line 32 in 1b876a9

$payload = \json_decode($message, true);

If I send not JSON then I see errors below in console.

2023-11-08T16:29:02.195Z ERROR   app             RuntimeException: Unable to decode a message from [0c3806ff-55f2-4219-92e8-b5795735060d] client. in /app/app/modules/Monolog/Interfaces/TCP/Service.php at line 36 [] []

I think we shoul write something like "Log message is not JSON!"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds better message for invalid monolog message format. buggregator/server
1 participant
@gam6itko