Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #398 #405

Closed
wants to merge 1 commit into from
Closed

Fix for issue #398 #405

wants to merge 1 commit into from

Conversation

leh103
Copy link
Contributor

@leh103 leh103 commented Mar 9, 2019

The changes in this pull request enables dlangide to be built on Linux which failed as per issue #398. Dlangide was built on lmde 3 version of Mint Linux and passed all tests using dub test.

@leh103
Copy link
Contributor Author

leh103 commented Mar 10, 2019

By the way, there is a fix for the unrolledlist.d file in the emsi-containers and that is to replace the "immutable uint notReg" in line 568 (and in line 566, althought it does not cause an error) with "auto notReg". This has not been fixed yet in the emsi-containers repository. So you have to do it to the the local repository that dub fetches for you. That is the reason for Travis Ci builds failing.

@leh103
Copy link
Contributor Author

leh103 commented Mar 17, 2019

The problem with unrolledlist.d in emsi-containgers has been fixed and merges into version 0.8.0-alpha13 release of this library. This pull request should now be able to pass all checks and people on linux will be able to build dlangide. Anyway I was able to build it ok.

@leh103
Copy link
Contributor Author

leh103 commented Mar 17, 2019

I do not know how to rerun the travis checks. Can anyone help me with this.

@cyian-1756
Copy link

@leh103 Try closing the PR and then opening it again

@leh103
Copy link
Contributor Author

leh103 commented Mar 24, 2019

Following cyian-1756's suggestion I am closing this pull request and then I am going to reopen it. The travis checks should pass since the emsi-containers unrolledlist.d file have been merged into the repo and when I built dlangide on linux the new emsi-containers version 0.8.0-alpha.13 was fetched and dlandide was build was OK and passed all test.

@leh103 leh103 closed this Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants