registry login: suppress bug report message on EOF #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user entering EOF (^D) when prompted does not warrant filing a bug report.
bufdev
reviewed
Dec 6, 2021
| return "", NewInternalError(err) | ||
| } | ||
| value = string(data) | ||
| } else { | ||
| scanner := bufio.NewScanner(container.Stdin()) | ||
| if !scanner.Scan() { | ||
| return "", NewInternalError(scanner.Err()) | ||
| // scanner.Err() returns nil on EOF. |
There was a problem hiding this comment.
Does it only return nil on io.EOF?
There was a problem hiding this comment.
Good question!
Yes, I believe nil is only possible on io.EOF or if the scanner's split func returns bufio.ErrFinalToken, which the default split func (bufio.ScanLines, which we're using here) never returns.
From https://pkg.go.dev/bufio#Scanner.Scan
After Scan returns false, the Err method will return any error that occurred during scanning, except that if it was io.EOF, Err will return nil.
bufdev
reviewed
Dec 6, 2021
| @@ -684,13 +685,20 @@ func promptUser(container app.Container, prompt string, isPassword bool) (string | |||
| if isPassword { | |||
| data, err := term.ReadPassword(int(file.Fd())) | |||
| if err != nil { | |||
| if errors.Is(err, io.EOF) { | |||
There was a problem hiding this comment.
comment as to why would be helpful
bufdev
approved these changes
Dec 6, 2021
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
A user entering EOF (^D) when prompted does not warrant filing a bug report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user entering EOF (^D) when prompted does not warrant filing a bug
report.