Add instruction on how to regenerate convert test data files #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyinma
commented
Nov 2, 2023
| @@ -1 +1 @@ | |||
| seconds: 3600 | |||
| seconds: 3600 | |||
There was a problem hiding this comment.
for some reason there are diff for txtpb format re: spaces, but shouldn't has any actual affect
bufdev
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these files shouldn't be regenerated to often as they are meant to be the wire format, hence not adding this as part of
make generate, but adding an instruction in case we do need to regenerate / others want to know how these are generated