Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify 'binpb' instead of 'bin' in the convert cmd help #2294

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Specify 'binpb' instead of 'bin' in the convert cmd help #2294

merged 1 commit into from
Jul 14, 2023

Conversation

Alfus
Copy link
Contributor

@Alfus Alfus commented Jul 13, 2023 •
edited
Loading

By fixing the constants.

Prev help output:
image
New output:
image

@Alfus Alfus changed the title Fix format constants Specify 'binpb' instead of 'bin Jul 13, 2023
@Alfus Alfus requested a review from bufdev July 13, 2023 22:51
@Alfus Alfus marked this pull request as ready for review July 13, 2023 22:51
@Alfus Alfus changed the title Specify 'binpb' instead of 'bin Specify 'binpb' instead of 'bin' in the convert cmd help Jul 13, 2023
bufdev
bufdev approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@bufdev bufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

@bufdev bufdev merged commit dfc8685 into main Jul 14, 2023
12 checks passed
@bufdev bufdev deleted the alfus/convert-help branch July 14, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufdev bufdev bufdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Alfus @bufdev